Skip to content

fix: list sharers with the same display name separately in the Shared By filter - #4152

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/shared-by-filter-dedupe-by-id
Nov 3, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/shared-by-filter-dedupe-by-id

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

The "Shared By" filter in Shared with me now lists every sharer, even when two people have the same display name, so each of them can be selected.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: filter items are deduplicated by id, so same-name sharers stay separate
  • test case 2: browser: two sharers named "Twin" both listed and selectable on desktop and Pixel 7, combined selection, reload; regular sharers still listed once, clear filter

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 4f3975f into main Nov 3, 2026
29 checks passed
@AlexAndBear
AlexAndBear deleted the fix/shared-by-filter-dedupe-by-id branch November 3, 2026 13:36
@openclouders openclouders mentioned this pull request Nov 3, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shared By filter merges sharers with the same display name

2 participants